#19459: Write (C++) patch for window resizing parts -------------------------------------------------+------------------------- Reporter: gk | Owner: | arthuredelstein Type: task | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-torbutton-conversion, | Actual Points: TorBrowserTeam201610 | Parent ID: | Points: Reviewer: | Sponsor: | SponsorU -------------------------------------------------+-------------------------
Comment (by gk): Okay, this looks mostly good to me I think. Two comments to the C++ code 1) We might want to add an `NS_ENSURE_STATE(shellWindow);` after and an `NS_ENSURE_STATE(mPrimaryContentShell);` before `nsCOMPtr<nsIBaseWindow> shellWindow(do_QueryInterface(mPrimaryContentShell));`. There is code that does this in r306252 and this seems reasonable to me. 2) We might want to check the return value of `GetAvailScreenSize()` called in `ResizeToBoundedDimensions()` as well (as is done at the other place you use it)? Not sure what should happen in case this fails, though. Regarding my testing: it looks good on all machines I tried it. I encounerted an issue I mentioned in comment:18 (1)) again but after digging a bit deeper it seems older versions have this problem, too. So, no regression at least. This is #18175 fwiw. I think we can leave the debugging statements in for now. The Torbutton patch looks good to me as well. Nice work! mcs/brade could you have a look at the C++ portion as well? -- Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/19459#comment:32> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs