#18873: Refactor circuit_predict_and_launch_new()
--------------------------+------------------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_review
Priority: Low | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: refactoring | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
--------------------------+------------------------------------
Comment (by chelseakomlo):
Replying to [comment:12 teor]:
> > Ok, great, that is good everything checks out for that refactor,
thanks!
> I think this looks good, and can be merged as-is. But I'd like someone
else to review it too.
Sounds great! My hesitation around adding more unit tests is the level of
mocking that is necessary to test certain functions. Maybe that topic can
be a larger conversation.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18873#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
