#19043: prop224: Implementation of ESTABLISH_INTRO cell -------------------------------------------------+------------------------- Reporter: alec.heif | Owner: asn Type: enhancement | Status: | merge_ready Priority: Medium | Milestone: Tor: | 0.3.0.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, prop224, 6.s194, | Actual Points: TorCoreTeam201611, review-group-11 | Parent ID: #17241 | Points: 6 Reviewer: asn, dgoulet | Sponsor: | SponsorR-must -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_review => merge_ready Comment: OK! I have a branch that is mature enough for Nick to take a look. It can be found in my repo at `ticket19043_030_02`. It basically allows Tor to parse and handle ESTABLISH_INTRO cells and also map them with circuits (using the new HS circuitmap subsystem). It's also able to generate ESTABLISH_INTRO cells, but this is just done to generate unit test data. It's squashed and rebased on git master. When the prop224 HSDir branch (#17238) gets merged, this branch will require some minimal edit so that we move some stuff to the `hs_common.c` file introduced by #17238 (there is an XXX about that). I will do that and rebase it when the time comes. I also tested it on chutney today and the current HS functionality seems to work just fine. More manual testing is always good. WRT unit testing, here is the coverage: {{{ File 'src/or/hs_circuitmap.c' Lines executed:99.05% of 105 File 'src/or/hs_intropoint.c' Lines executed:84.52% of 84 File 'src/or/hs_service.c' Lines executed:80.39% of 51 }}} Please note that `hs_service.c` is unused by real code yet (it's just there basically to generate unittest vectors). Please let me know if you need me to do anything else here. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19043#comment:34> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs