#20853: rend_config_services should use service_is_ephemeral rather than old/new->directory ------------------------------------+------------------------------------ Reporter: teor | Owner: jryans Type: defect | Status: needs_review Priority: Medium | Milestone: Tor: 0.3.0.x-final Component: Core Tor/Tor | Version: Tor: 0.2.9.5-alpha Severity: Normal | Resolution: Keywords: easy refactor intro hs | Actual Points: Parent ID: | Points: 0.1 Reviewer: | Sponsor: ------------------------------------+------------------------------------
Comment (by jryans): Further updates to the patch at https://github.com/jryans/tor/commits/service_is_ephemeral after discussing on IRC: * Cleaned up format of the conditionals to read more clearly * Use `return -1` with poison checks * Add checks to `rend_service_poison_new_single_onion_dir` as well * I pulled up the log message for ephemeral services from `rend_service_poison_new_single_onion_dir_impl` since checking for this case in `rend_service_poison_new_single_onion_dir` would omit the message -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20853#comment:11> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs