#20458: Integration tests should be run locally before committing code changes ----------------------------------------------+---------------------------- Reporter: chelseakomlo | Owner: | chelseakomlo Type: enhancement | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: test, doc, triage-out-030-201612 | Actual Points: Parent ID: | Points: Reviewer: teor | Sponsor: ----------------------------------------------+---------------------------- Changes (by chelseakomlo):
* status: assigned => needs_review Old description: > Currently, it is easy to submit a patch for code changes without first > running integration tests locally. > > Two changes could help with this: > 1. Adding this information to documentation for contributors > 2. Adding a make task that runs all necessary tasks before contributing > new code, which are: > > `make check-spaces` > `make check .` > `make test-network-all` > > We should investigate how to handle: > - Someone not having have chutney > - Someone not having the necessary network connection for integration > tests to succeed > - If chutney tests fail because of flakiness (race conditions for > example) rather than legitimate failures. New description: Currently, it is easy to submit a patch for code changes without first running integration tests locally. Two changes could help with this: 1. Adding this information to documentation for contributors 2. Adding a make task that runs all necessary tasks before contributing new code, which are: `make check-spaces` `make check` `make test-network-all` We should investigate how to handle: - Someone not having have chutney - Someone not having the necessary network connection for integration tests to succeed - If chutney tests fail because of flakiness (race conditions for example) rather than legitimate failures. -- -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:20> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs