#21272: Onionperf deployment -------------------------+------------------------------ Reporter: hiro | Owner: metrics-team Type: enhancement | Status: needs_review Priority: Medium | Milestone: Component: Metrics | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------+------------------------------
Comment (by iwakeh): Replying to [comment:23 karsten] and what's left from [comment:18]: > iwakeh, please find my updated task-21272 branch with some tweaks as discussed above. Thanks, for these changes! Couldn't `downloadFromOnionPerfHost` do some of the filename checking before calling `downloadAndParseOnionPerfTpfFile`? About the older code: Could we just also make the change for #20514 now? In addition, there are quite a few places where try-with resources or some of `Files`' methods would prevent unclosed readers/writers. Still this older code needs even more work, sigh. Maybe, after Amsterdam? And, regarding the descriptor parsing don't the checks inside [https://gitweb.torproject.org/karsten/metrics- db.git/tree/src/main/java/org/torproject/collector/torperf/TorperfDownloader.java?h=task-21272&id=3318eb8ca769392cca1a6ddc3344c43eba62da91#n797 this loop] belong into descriptor/metrics-lib itself? (that might be a new ticket, though) I can take a look at the Persistence topic at some point. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21272#comment:25> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs