#21747: Requesting a new circuit for a site is not working in ESR 52 based Tor
Browser
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
| arthuredelstein
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-torbutton, ff52-esr, | Actual Points:
tbb-7.0-must, TorBrowserTeam201703R, tbb-7.0 |
-must-nightly |
Parent ID: #21201 | Points:
Reviewer: | Sponsor:
| Sponsor4
-------------------------------------------------+-------------------------
Comment (by arthuredelstein):
Replying to [comment:9 mcs]:
> r=brade, r=mcs
> This patch looks okay and it seems to work. Why did you need to add the
following code?
> {{{
> if (domain === "") {
> domain = "--unknown--";
> }
> }}}
Thanks for the review. Traditionally we have used "--unknown--" for the
catchall domain (and SOCKS username). But for a chrome-initiated request,
originAttributes.firstParty is an empty string. So this line ensures that
request goes through the "--unknown--" circuit.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21747#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
