#13398: at startup, browser gleans user FULL NAME (real name, given name) from 
O/S
--------------------------------------+--------------------------------
 Reporter:  zinc                      |          Owner:  pospeselr
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201708R =>
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:15 pospeselr]:
 > Ok uploaded new patch without white-space issues and with adjusted if
 spacing and mcs's suggested code changes.  Also verified patch behaves as
 expected at runtime.
 >
 > Rest of the night goes to seeing if I can build OSX flavor using rbm.

 I have not tested an OS X build yet but the Windows one (done with
 `mingw-w64`) is failing with:
 {{{
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:29:45: error:
 ambiguating new declaration of 'nsresult
 nsUserInfo::GetUsernameImpl(char**)'
  nsUserInfo::GetUsernameImpl(char **aUsername)
                                              ^
 In file included from /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:6:0:
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfo.h:27:12: note: old
 declaration 'nsresult nsUserInfo::GetUsernameImpl(char**)'
    nsresult GetUsernameImpl(char** aUsername);
             ^
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:45:49: error:
 ambiguating new declaration of 'nsresult
 nsUserInfo::GetFullnameImpl(char16_t**)'
  nsUserInfo::GetFullnameImpl(char16_t **aFullname)
                                                  ^
 In file included from /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:6:0:
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfo.h:26:12: note: old
 declaration 'nsresult nsUserInfo::GetFullnameImpl(char16_t**)'
    nsresult GetFullnameImpl(char16_t** aFullname);
             ^
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:97:41: error:
 ambiguating new declaration of 'nsresult
 nsUserInfo::GetDomainImpl(char**)'
  nsUserInfo::GetDomainImpl(char **aDomain)
                                          ^
 In file included from /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:6:0:
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfo.h:29:12: note: old
 declaration 'nsresult nsUserInfo::GetDomainImpl(char**)'
    nsresult GetDomainImpl(char** aDomain);
             ^
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:116:53: error:
 ambiguating new declaration of 'nsresult
 nsUserInfo::GetEmailAddressImpl(char**)'
  nsUserInfo::GetEmailAddressImpl(char **aEmailAddress)
                                                      ^
 In file included from /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfoWin.cpp:6:0:
 /home/ubuntu/build/tor-
 browser/toolkit/components/startup/nsUserInfo.h:28:12: note: old
 declaration 'nsresult nsUserInfo::GetEmailAddressImpl(char**)'
    nsresult GetEmailAddressImpl(char** aEmailAddress);
             ^
 make[5]: Leaving directory `/home/ubuntu/build/tor-browser/obj-
 mingw/toolkit/components/startup'
 make[5]: *** [nsUserInfoWin.o] Error 1
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13398#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to