#24175: Use an embedded Jetty in metrics-web and use metrics-base as build environment. -----------------------------+------------------------------ Reporter: iwakeh | Owner: iwakeh Type: enhancement | Status: needs_review Priority: Medium | Milestone: Component: Metrics/Website | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------+------------------------------ Changes (by iwakeh):
* status: accepted => needs_review Comment: First of all thanks for the data, it helped a lot! Please review the thirty something commits on [https://gitweb.torproject.org/user/iwakeh/metrics- web.git/log/?h=task-24175-stepbystep this patch branch]. I didn't change anything, only ironed out tiny things. The commits are for ease of review and partially examples for refactoring the modules, not so much suited for cherry picking. I created a ticket for removing the dependency on server locale. Most of comment:2 applies. The open topic is solved with having data, but this is not part of this restructuring ticket. This reproducibility issue concerns the two oldest dbs: userstats and tordir. The R issue (mentioned in comment:2) in the clients module doesn't show up when a sufficient amount of data is available. What is not really reproducible from scratch is the tordir database (the oldest db here). This issue has nothing to do with restructuring as it concerns the initial db setup. The refresh_all call in the legacy module fails at call refresh_network_size. After adding more data and running the other refresh functions by hand: refresh_all suddenly works. This should be investigated in its own ticket in addition to the inconsistencies of the main db and the db setup, i.e. there are still functions in the data dump that are not in the sql scripts, for example: refresh_oldest_week. After ant war and jar: steps for setting up metrics-web: `ant run-web- prepare` prepares everything, `ant run-rserver` starts the R daemon, and `java -DLOGBASE=logs -jar generated/dist/metrics-web-1.0.0-dev.war` starts jetty. Two more tickets needed: one each for making the setup of userstats and tordir db reproducible from scratch. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24175#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs