#9390: Warn if you're being a public relay but have too-low file descriptor limit -------------------------------------------------+------------------------- Reporter: arma | Owner: (none) Type: enhancement | Status: | needs_revision Priority: Medium | Milestone: Tor: | unspecified Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-relay easy dos resources | Actual Points: logging | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by teor): Thanks for this patch. There is one remaining bug in this patch: we can't have set_max_file_descriptors() return -1 if there aren't enough file descriptors, because that causes options_act_reversible() to fail. We just want to warn the relay operator. Here are the other things that someone will need to do before we merge it: * change the spacing to conform to our coding style: * two spaces indent, * spaces after "if" and before "{" * replace 8192 with a "#define" constant. For an example, look at how "ULIMIT_BUFFER" is defined, used, and commented * change the log message so it tells the operator what they can do to fix the issue ("raise the file descriptor limit, or install tor using a package manager") * add a comment that explains why we are doing the check -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9390#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs