#16513: Make writing of the out/ directory from the status/ directory
deterministic
-----------------------------+-------------------------------
Reporter: karsten | Owner: metrics-team
Type: enhancement | Status: merge_ready
Priority: High | Milestone: Onionoo-2.0.0
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: metrics-2018 | Actual Points:
Parent ID: | Points:
Reviewer: iwakeh | Sponsor:
-----------------------------+-------------------------------
Comment (by karsten):
Replying to [comment:21 iwakeh]:
> All tests and checks pass and code looks ok.
Awesome!
> Shouldn't the new method parameter 'long now' (in various methods) be
named differently to reflect the meaning of the milliseconds timestamp?
Maybe 'long lastMeasurementMillis' or similar?
Good point. Let's go with `lastSeenMillis` which is what we use in
`NodeStatus`, too. I'll change that before merging.
> How will the data be affected when deploying the fix? The stored data
timestamps might be more recent than the last seen value used in the new
code. Did you run system tests on a local instance?
> This should be clarified before deployment, but the code is merge ready.
I'll run another local test before merging. Once that's done, let's
coordinate deployment as usual.
Thanks for the review!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16513#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
