#24658: Split/refactor crypto.h into smaller separate modules -------------------------------------------------+------------------------- Reporter: isis | Owner: (none) Type: enhancement | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-crypto, refactor, review- | Actual Points: group-29, review-group-31 | Parent ID: | Points: Reviewer: | Sponsor: | Sponsor8-can -------------------------------------------------+-------------------------
Comment (by nickm): hm. I like all of this except for the part that makes the contents of crypto_pk_t public. Generally it's better to keep structure contents like this opaque whenever we can. Two options here would be: moving the crypto_pk_digest functions into crypto_rsa, or making them use crypto_pk_asn1_encode() instead. I tried the latter approach in a squash commit I made on top of `bug24658-rsa` in my public branch of the same name. Does it look ok to you? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24658#comment:18> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs