#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-----------------------------+------------------------------------
 Reporter:  icanhasaccount   |          Owner:  (none)
     Type:  defect           |         Status:  needs_revision
 Priority:  Low              |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Minor            |     Resolution:
 Keywords:  review-group-31  |  Actual Points:
Parent ID:                   |         Points:  .2
 Reviewer:  nickm            |        Sponsor:
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 (I'm guessing that the second patch should be applied _without_ the first,
 right?)

 I like this patch, but I'm not so sure about having jemalloc be the
 default right away.  Let's let people test it as an option before we
 decide it's the best choice for everyone. Also, if I'm reading the patch
 right, this code will break on Linux if jemalloc isn't installed, which
 probably isn't what you'd intended?

 Other questions:
   * Why move the mlockall check?
   * Why does the patch move dmalloc?  Have you tested this?  Does it work?
   * Where and how have you tested this patch?

 Other notes:
   * This will need a changes file, explaining to people how to use this
 feature.
   * We'll still want to remove the openbsd_malloc code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20424#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to