#22926: The Tor compression code can call functions that are NULL
-----------------------------+------------------------------------
Reporter: teor | Owner: ahf
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.1.1-alpha
Severity: Normal | Resolution:
Keywords: review-group-32 | Actual Points:
Parent ID: | Points: 1
Reviewer: mikeperry | Sponsor:
-----------------------------+------------------------------------
Changes (by mikeperry):
* status: needs_review => needs_revision
Comment:
It has been a while since I have done autoconf, but as far as that goes,
this looks good - has a sane default for cross compile given the situation
(assume it works).
As to the larger question, I can see an argument for just going this check
for one library to check if lazy linking is enabled globally. But there
probably should be a comment in the autoconf test to say that's what we're
doing (and why we are only testing this with one library). Marking
needs_revision for that.
Also make check-changes fails because of the # in the bug line.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22926#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
