#25387: Add comment section to CSV file headers
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by iwakeh):

 Replying to [comment:1 karsten]:
 > I started an implementation in [https://gitweb.torproject.org/karsten
 /metrics-web.git/log/?h=task-25387 my task-25387 branch]. It's also
 temporarily deployed right now, but not merged to master yet.
 >
 > In contrast to the suggestions above, I added the header in Java, not in
 R. I think that's going to be more flexible if we make the header more
 complex.

 Using Java for all this is surely the better solution here.

 >
 > I did not yet include parameters or a legend. That will require more
 effort and might not be done this week. If the current changes look okay,
 I'll merge and deploy permanently. We could still keep this ticket open to
 do more.

 I understand that legend is some more work, but parameter would be simply
 adding 'HttpServletRequest::getQueryString()' to the Url:
 `request.getRequestURI() + "?" + request.getQueryString()`.
 The complete URL including parameters is important for reproducing the csv
 files.

 With added parameters this patch is merge ready and this ticket would be
 finished.
 For the legend descriptions we should open a new ticket as part of the
 sponsor13 work?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25387#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to