#25387: Add comment section to CSV file headers
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  enhancement      |         Status:  closed
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:  fixed
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:2 iwakeh]:
 > Replying to [comment:1 karsten]:
 > > I did not yet include parameters or a legend. That will require more
 effort and might not be done this week. If the current changes look okay,
 I'll merge and deploy permanently. We could still keep this ticket open to
 do more.
 >
 > I understand that legend is some more work, but parameter would be
 simply adding 'HttpServletRequest::getQueryString()' to the Url:
 `request.getRequestURI() + "?" + request.getQueryString()`.
 > The complete URL including parameters is important for reproducing the
 csv files.

 Changed!

 > With added parameters this patch is merge ready and this ticket would be
 finished.

 Great! Merged and deployed the changed branch.

 > For the legend descriptions we should open a new ticket as part of the
 sponsor13 work?

 Yes, I'll do that. Closing this ticket. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25387#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to