#24767: All relays are constantly connecting to down relays and failing over and over -------------------------------------------------+------------------------- Reporter: arma | Owner: dgoulet Type: enhancement | Status: | needs_review Priority: Very High | Milestone: Tor: | 0.3.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-relay, tor-dos, performance, | Actual Points: review-group-32, 033-must, review-group-34, | 033-triage-20180320, 033-included-20180320 | Parent ID: | Points: Reviewer: asn | Sponsor: -------------------------------------------------+------------------------- Changes (by dgoulet):
* status: needs_revision => needs_review Comment: Replying to [comment:34 dgoulet]: > Replying to [comment:31 nickm]: > > So on the hash function: You can't use a memcpy(tor_addr_t) like that, because some of the bytes of the tor_addr_t can be unspecified. I can fix that up. > > Oh damn because of the union, if it is a v4, we'll copy bunch of uninit bytes from the larger v6. I guess setting the size according to the family is the way to do it. Ok, did an attempt of this in fixup `53a26acb6172b7eb`. Not the prettiest but I don't see a way. Maybe we can abstract that in an inline function somehow like "tor_addr_get_ptr_size()" or sth around those lines? Still branch: `bug24767_033_02` -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24767#comment:35> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs