#25511: Expose TZ info on control port for better debugging of time errors
 Reporter:  nickm                                |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  roadmap, controller, 034-roadmap-    |  Actual Points:
  master, 034-triage-20180328,                   |
  034-included-20180328, s8-errors               |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor8

Comment (by catalyst):

 I just noticed that there might be a race condition if the time of day
 changes its seconds value between the calls to `tor_gettimeofday()` and
 `getinfo_helper_current_time()`.  Maybe this happens rarely enough in
 practice that it won't be a problem.

 If it is a problem, mocking `tor_gettimeofday()` to return a fixed value
 might be the best solution.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25511#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
tor-bugs mailing list

Reply via email to