#25481: Ship tor in Tor Browser nightly builds on Linux with Rust enabled
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201804,          |  Actual Points:
  boklm201804, TorBrowserTeam201804              |
Parent ID:  #25220                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, GeorgKoppen201804, boklm201804, TorBrowserTeam201804R
     => tbb-rbm, GeorgKoppen201804, boklm201804, TorBrowserTeam201804


Comment:

 Replying to [comment:6 gk]:
 > So, I worked around that by building LLVM during the rust compilation
 (which make the whole process taking significantly more time) using that
 version in turn.

 I don't see LLVM being built in your patch. Is it done internally by the
 rust build system?

 The extracting of gcc and update of the PATH/LD_LIBRARY_PATH could be
 replaced by:
 {{{
 [% pc('gcc', 'var/setup', { compiler_tarfile =>
 c('input_files_by_name/gcc') }) %]
 }}}
 However it will also set hardened-cc links. Is it because the build
 doesn't work with hardened-cc that you didn't use it?

 For the `ln -s gcc cc` link, I am wondering if we should add it directly
 in `projects/gcc/build`, or if there are cases where we might not want
 this link.

 In `projects/tor/build`, I think the lines after the `IF c("var/linux") &&
 c("var/nightly")` can be indented.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25481#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to