#24378: Prune the list of supported consensus methods
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix                                            |
Parent ID:                                       |         Points:  .5
 Reviewer:  isis, teor                           |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * reviewer:  isis => isis, teor


Comment:

 Looks good to me, I left a review on github with two nitpick changes:
 * fix some missing words in a commit message
 * please don't remove a unit test for a far future consensus method

 We will also need a dir-spec change like this one:
 {{{
 [ As of 0.2.6.1-alpha, authorities no longer advertise or negotiate
           any consensus methods lower than 13. ]
 }}}

 I'm not sure if isis also wants to review this code.

 Let's also make sure someone has run "make test-network-all" on this
 branch on an IPv6/mixed system, with tor-stable linked to 0.2.9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24378#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to