#25762: Make periodic events array with flags including when they are enabled/disabled -------------------------------------------------+------------------------- Reporter: dgoulet | Owner: dgoulet Type: defect | Status: | assigned Priority: Medium | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: 034-roadmap-subtask, client, | Actual Points: s8-perf | Parent ID: #25500 | Points: Reviewer: | Sponsor: | Sponsor8 -------------------------------------------------+-------------------------
Comment (by dgoulet): Replying to [comment:6 nickm]: > This needs unit tests, and I also want to review these remaining things that I didn't check when I was reviewing the initial branch: > * Did we accidentally "lose" any periodic callbacks? Yah... I think this means someone needs to go over commit f9370609e49e72d0 and make sure I didn't forget one :S. > * Are all of the flags set correctly? Indeed. Same commit from above. It is possible an event applies to a role I failed to notice... > > Also: > * We should decide how this approach will handle events that turn off when DisableNetwork is set. I think we can do this part of #25376 and not within this branch. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25762#comment:7> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs