#25750: update Tor Launcher for ESR 60
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:  brade
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Launcher       |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  ff60-esr, TorBrowserTeam201805R => ff60-esr,
     TorBrowserTeam201805


Comment:

 Some comments (just nits):

 commit 785568d05b12f819a29b90c2dcd4e55b821a2047:
 Any reason why the `minVersion` for Fennec is 45 and not 52? (I am fine
 with leaving the patch you have given that we are not really enforcing 52
 for desktop either, just curious)

 commit 2e1e760a8393de281318e97ef44b2e89ba67879c
 "Gecko now requires "0o"-prefixed octal literals" <- Are you sure about
 that? Yes, the warning shows up in the browser console but the bug you are
 citing is already fixed in Firefox 48, yet Tor Browser 7 does not show the
 warning. Fixing the octals is good, though. I hunted a bit but finding the
 actual bug behind this change seems a bit tricky. I think we could just
 say "Fix deprecated octal literals" in the commit message and move on.

 You are using "Bug XXXXXXX" and "bug XXXXXXX" for referencing Mozilla bugs
 within a sentence. I think you should stick to one format and the latter
 is the better one.

 commit 039bd44ce1a65bbc7bcacfa7a6b114b744a84b8f

 s/var loader/let loader/
 {{{
 +      TorLauncherLogger.log(5,"Ignoring invalid pref ending with a
 period: '" +
 }}}
 Whitspace between "," and "\"".

 You want to have pairwise "'" but are forgetting sometimes the closing
 one.

 commit 3f2936d1323c36d1882b81ab155bf9fd48e27a37

 The indentation of the new code block is off by one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25750#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to