#26520: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser ---------------------------------------------+----------------------------- Reporter: gk | Owner: tbb-team Type: defect | Status: | needs_review Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: ff60-esr, TorBrowserTeam201807R | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: ---------------------------------------------+-----------------------------
Comment (by rustybird): > Here's a patch for review: > https://github.com/arthuredelstein/torbutton/commit/26520 Now it seems to fire too late - on first site load (not including about:tor). If that first loaded site contains JavaScript, it will be disabled there. Tested on e.g. https://enable-javascript.com I tried with a line `log(5, "XXX sending");` added inside the `sendNoScriptSettings` function and noticed that both the first site load and moving the slider resulted in //multiple// messages to NoScript - not sure if that's a problem. (Slightly related, `noscript-control.js` has a guard against the `initialized` variable, but it's never set to `true`.) `log(e.message);` -> `log(5, e.message);` -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26520#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs