#27016: TBA: Audit thirdparty picasso ------------------------------------------+------------------------------ Reporter: sysrqb | Owner: tbb-team Type: defect | Status: needs_review Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-mobile, tbb-proxy-bypass | Actual Points: Parent ID: #25851 | Points: Reviewer: | Sponsor: ------------------------------------------+------------------------------
Comment (by sysrqb): Replying to [comment:2 sysrqb]: > Replying to [comment:1 sysrqb]: > > This library using the `NetworkInfo` via the `ConnectivityManager` for deciding how many background threads it should create for processing. Higher bandwidth connections result in more threads. The default is 3, so this shouldn't be a problem. The library also registers for network change events. We'll probably need to change it so we don't require these Android permissions. > > > > This doesn't seem like it'll be a problem. Picasso catches missing permissions, so that shouldn't be cause a crash. I should note here, Picasso watches when "airplane mode" is enabled and disabled so it knows when it should retry downloading a file or failing (fail if airplane mode is enabled). I'm assuming we can safely keep this, for now. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27016#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs