#27088: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS -------------------------------------------------+------------------------- Reporter: teor | Owner: teor Type: defect | Status: | merge_ready Priority: Medium | Milestone: Tor: | 0.3.5.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.4.1-alpha Severity: Normal | Resolution: Keywords: not-just-linux, tor-ci, teor-was- | Actual Points: assigned, 034-triage-20180328, | 034-removed-20180328, 034-backport, | 035-removed-20180711, fast-fix | Parent ID: #24629 | Points: Reviewer: catalyst | Sponsor: -------------------------------------------------+------------------------- Changes (by catalyst):
* status: needs_review => merge_ready Comment: Looks good! I'm not sure I like passing configure options that begin with `--` as the first argument to `echo`. Maybe put some text that doesn't start with a dash first? Like `echo configuring with flags $CONFIGURE_FLAGS`? On the other hand, I think the shells that Travis uses on all its platforms will tolerate it, so maybe we can let that remain. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27088#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs