#26514: intermittent updater failures on Win64 (Error 19) --------------------------------------+------------------------------ Reporter: mcs | Owner: tbb-team Type: defect | Status: needs_review Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201808R | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------+------------------------------ Changes (by mcs):
* status: new => needs_review * keywords: TorBrowserTeam201808 => TorBrowserTeam201808R Comment: Replying to [comment:19 jacek]: > As a less radical solution could be using fseek64 and ftello64. Those are much thinner wrappers in mingw-64 around msvcrt.dll. You could try that by changing defines in mar_private.h Thank you for your analysis and for this suggestion. It appears to solve the problem nicely. After reading the other code (ftelli64 and _fseeki64), it is difficult to say where the problem is but some aspects seem to rely on internal Microsoft flags, etc. and certainly there is complexity there (as you said). Anyway, here is a patch that works for Kathy and me: https://gitweb.torproject.org/user/brade/tor- browser.git/commit/?h=bug26514-01&id=c2720b2274e51eb76b91e5f6a5f2a82bdfaf8013 We tested on an up-to-date Windows 10 system. 200 incremental updates and 200 complete updates all completed without any signature verification failures. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26514#comment:20> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs