#27761: check-changes: check that bugfixes aren't on future versions --------------------------+------------------------------------ Reporter: teor | Owner: teor Type: enhancement | Status: needs_review Priority: Medium | Milestone: Tor: 0.3.5.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: fast-fix | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------+------------------------------------
Comment (by teor): Replying to [comment:2 cypherpunks3]: > Replying to [ticket:27761 teor]: > > I tried to modify lintChanges.py to check for bugfixes against future versions. But then I realised that we backport bugfixes. > > > > So I salvaged the version parsing code into a new check. > > But don't you only backport bugfixes to versions that already have the bug? You're right, yes, we do. (But I bet we've got that wrong in the past, and backported bugfixes that say they're for a later version.) All the current changes files pass this new check, so let's see how we go. See my branch ticket27761, or https://github.com/torproject/tor/pull/353 . I also tested that "bugfix on 0.3.5.1-alpha" works, but 0.3.5.2-alpha and 0.4.5.1-alpha fail the check. I backported the change to 0.2.9 and 0.3.2, to check that their changes files pass this new check: * https://travis-ci.org/teor2345/tor/branches (But I don't think we need to backport this change.) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27761#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs