#27438: Android Gradle Build Downloads -------------------------------------------------+------------------------- Reporter: sisbell | Owner: tbb- | team Type: defect | Status: | needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-rbm, tbb-mobile, | Actual Points: TorBrowserTeam201810 | Parent ID: #26693 | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by sisbell): Replying to [comment:14 boklm]: > For a review of commit `27604107dca4992aac4a2f3b015f5a7c4273a606`: > - does `maven-repo-1.0.tar.gz` contains the dependencies that are specific to firefox? If so then I think it should be moved to `projects/firefox/config` instead of `projects/android-toolchain/config`. In the future `android-toolchain` will be used to build other components than firefox, such as Tor. > > A lot of these artifacts will be duplicated between projects, meaning we may be downloading and archiving multiple times. Would that be a problem? > - the name of the file `README.ANDROID` is a little confusing, as it doesn't really talk about android but only about how to generate a maven repo archive. Maybe that could be renamed to something like `projects/firefox/how-to-generate-maven-repo.txt`? >> Sounds good > - `curl https://sh.rustup.rs -sSf | sh` does not look like a safe way to install rust. Would that work if we just suggested installing the `rustc` package from the distribution? >> It can be downloaded and used like we do in projects/rust > - I don't know much about cargo, but do I understand correctly that `cargo install artc` is downloading artc binaries from https://crates.io/? If so, is there some way this can be done by building https://github.com/sisbell/artc from sources? >> crates just has the source and builds from that. ~/.cargo/registry/src/artc contains the source. But yes, it can also be downloaded directly from git and run. > - How was `download-urls-1.0.txt` from https://github.com/sisbell/tor- android-repo generated? Maybe we should include that file directly into `tor-browser-build` (for instance in the projects/firefox directory) instead of storing it in a separate git repo. >> I put info on how its generated in the readme file of the tor-android- repo. Basically, I just grep the gradle logs and pull out the URLS. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27438#comment:16> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs