#28127: Hidden service option HiddenServiceAuthorizeClient is incompatible with
version 3
-----------------------------+------------------------------------
Reporter: pege | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.5.1-alpha
Severity: Normal | Resolution:
Keywords: tor-hs, hs-auth | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Comment (by dgoulet):
We've identified a couple issue:
1) If `HiddenServiceVersion` is explicitly set, it should be respected for
the entire configuration process that is not even call the "learn version
from the keys" mechanism.
2) If (1) is not set, then we should learn the version _early_ and *then*
look for invalid options. Right now, the issue above is because tor stops
as it found an invalid option while thinking it was a v3 but in reality
was v2 because no v3 keys exist on disk.
3) In the code, the code below is wrong. `config_learn_service_version()`
returns -1 if not keys were found to detect the version instead of the
already configured version which is what is documented. Trivial fix but
should be fixed!
{{{
service->config.version = config_learn_service_version(service);
switch (service->config.version) {
...
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28127#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
