#28113: notify systemd if shutdown will be longer than 30 seconds -------------------------------------------------+------------------------- Reporter: Hello71 | Owner: Hello71 Type: defect | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.3.5.x-final Component: Core Tor/Tor | Version: Tor: | 0.2.6.2-alpha Severity: Normal | Resolution: Keywords: tor-systemd, 029-backport-maybe, | Actual Points: 033-backport-maybe, 034-backport-maybe, 035 | -backport-maybe | Parent ID: | Points: Reviewer: teor | Sponsor: -------------------------------------------------+-------------------------
Comment (by Hello71): Replying to [comment:6 teor]: > Please see my comments on the pull request. Replied there. > We should test this pull request in an alpha before backporting it. Agreed. Replying to [comment:7 teor]: > (It's pretty safe, because it only extends the systemd timeout. But we should check it doesn't extend the timeout too much.) As I explained on the PR, it doesn't matter too much if the number sent is too high, since systemd will continue immediately as long as tor actually exits before the timeout (it's a maximum limit, not a minimum or exact). If tor doesn't exit expeditiously, then that's a bug in tor. IMO it's worth trying to work around the (still hypothetical AFAIK) bug by waiting a little longer, rather than crashing and almost certainly corrupting cache files. Also, I figure nobody will care excessively if they set ShutdownWaitLength to 2 minutes and tor actually takes 2 minutes 15 seconds to quit, as long as we don't accidentally make it 20 minutes (but again, that would require another separate bug in tor). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28113#comment:9> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs