#27443: Update Firefox RBM config and build for Android
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, tbb-mobile, TBA-a2, | Actual Points:
TorBrowserTeam201811 |
Parent ID: #26693 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Okay, I spent quite some time testing and reviewing the updated patch. I
feel we are close. Here are three things that I found so far which should
be fixed:
1) You have `--disable-strip` in the mozconfig file. Please use `--enable-
strip` instead (even though the resulting binaries are indeed stripped),
as this is less confusing.
2) Could you add a comment in the mozconfig file above
{{{
ac_add_options --with-libclang-path=/var/tmp/dist/android-toolchain
/android-ndk/arm/lib64
ac_add_options --with-clang-path=/var/tmp/dist/android-toolchain/android-
ndk/arm/bin/clang
}}}
explaining that we need that for the Stylo build part and the preferred
way, using `LLVM_CONFIG`, is not available as there is no `llvm-config` in
the ndk. (at least I could not find it)
3) The gradle deps download script mentions issues with setting
`LC_ALL=C`. Please add the bug number as reference (it is #28117).
Finally, could you explain what breaks without setting `--with-android-
version=22`? You mentioned "22 is the highest version that works" but what
does that mean?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27443#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
