#28458: Stop resolving domains locally and stop using non-exits as 2nd hop
---------------------------+--------------------------------
Reporter: juga | Owner: juga
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Core Tor/sbws | Version: sbws: 1.0.0
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------+--------------------------------
Comment (by teor):
Replying to [comment:6 juga]:
> We were checking bad exit, exit policy and exit in different ways in
different parts of the code.
Sounds like you need to refactor the code so you check the flags and exit
policy in a single function.
> The local domain resolver is only needed to check the IP in the policy,
which i don't think is needed, it will fail and be measured later with a
probably different exit.
But what happens when the exit that's being measured fails?
Do we need to give it a 50% chance of being measured like a non-exit?
> With the changes i've made, i check only the port, but check it in all
attempts to get an exit.
> I also found that the port was not not being correctly parsed.
> The changes solve the problem of having a local domain resolver that
fails.
> I'm running a testing instance and is being faster, failing less
circuits.
Ok, sounds good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28458#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
