#28725: Upgrade go-webrtc to dcbfc825aa33471253a5da1834d499257e05d557 -------------------------------------------------+------------------------- Reporter: dcf | Owner: tbb- | team Type: task | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: snowflake tbb-rbm, | Actual Points: TorBrowserTeam201812R | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by dcf):
* status: needs_revision => needs_review * keywords: snowflake tbb-rbm, TorBrowserTeam201812 => snowflake tbb-rbm, TorBrowserTeam201812R Comment: Sorry about that. I didn't get any error from a full `make testbuild`, neither when I originally staged the patch on 3e75d4bbf273c1494ff9442c67c0dda1f86c6eac, nor when I tried rebasing on 30c764db2bbbde93ebee67e2b190a4d9c88873b9 yesterday. I don't even have a directory called `gclient/webrtc/src/third_party/llvm`; mine is called `gclient/webrtc/src/third_party/llvm-build`. Nevertheless, I am guessing from the error message that there is a problem with whitespace in filenames. Here's a revised patch that rewrites the `for` loops to instead use whitespace-safe `find -print0` and `xargs -0`. This additional patch doesn't affect the output for me; i.e., my corresponding out/webrtc/webrtc-*.tar.gz files are the same except for the gzip timestamp. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28725#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs