#28852: Remove memset() from get_token_arguments. ---------------------------------+------------------------------------ Reporter: nickm | Owner: nickm Type: defect | Status: merge_ready Priority: Medium | Milestone: Tor: 0.4.0.x-final Component: Core Tor/Tor | Version: Tor: 0.3.4.9 Severity: Normal | Resolution: Keywords: startup performance | Actual Points: 0 Parent ID: #28481 | Points: Reviewer: catalyst | Sponsor: Sponsor8-can ---------------------------------+------------------------------------ Changes (by catalyst):
* status: needs_review => merge_ready Comment: Looks good to me! I'm not completely convinced that we check `tok->n_args` every place we need to, but that's an existing problem that I think isn't made worse by this change, because we already weren't copying any terminating null pointer that we might have gotten when we were calling `memset()`. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28852#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs