#29120: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable -------------------------------------------------+------------------------- Reporter: QZw2aBQoPyuEVXYVlBps | Owner: tbb- | team Type: defect | Status: new Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-disk-leak, tbb-usability- | Actual Points: website, TorBrowserTeam201901 | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by QZw2aBQoPyuEVXYVlBps): Alright, I poked around the code a little more and I think I found a decent solution. I changed {{{GetMediaCache}}} to add a {{{aIsPrivateBrowsing}}} parameter. As far as I can tell, {{{GetMediaCache}}} is only ever called from {{{MediaCacheStream::Init}}}, so I just changed the call there to pass in the stream's {{{mIsPrivateBrowing}}} member. The rest of the code is pretty similar to the previous patch, but the new logic only applies in private browsing mode now. I added and updated a few comments in the code to reflect the new behavior as well. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs