#30206: Segfault in proxy-go
-------------------------------------+------------------------
Reporter: irl | Owner: cohosh
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution: fixed
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+------------------------
Comment (by arlolra):
If `sendAnswer()` returns an error, `pc.Destroy()` is called and the token
is returned,
https://github.com/keroserene/snowflake/blob/master/proxy-
go/snowflake.go#L370
However, `makePeerConnectionFromOffer()` will have now set a timeout that
will also call `pc.Destroy()`,
https://github.com/keroserene/snowflake/blob/master/proxy-
go/snowflake.go#L345
This patch moves the timeout to after `sendAnswer` returns,
https://github.com/keroserene/snowflake/commit/2e4383434f33a4f8e801974bbe70d8a4568b3d93
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30206#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
