#30683: Properties in dom/locales/$lang/chrome/ allow detecting user locale -------------------------------------------------+------------------------- Reporter: gk | Owner: tbb- | team Type: defect | Status: | needs_revision Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-fingerprinting-locale, | Actual Points: TorBrowserTeam201907 | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by mcs): Replying to [comment:6 gk]: > I think this looks mostly good to me. Could you adapt > `// When we spoof English, use en-US default strings in HTML forms.` a bit as the code that follows is not only about forms anymore? Maybe something like: `// When we spoof English, use en-US properties in strings that are accessible by content.` > Have you checked whether the patch is a good upstreaming idea as-is? I wonder in particular if the `en-US` strings will always be available in, say `fr`, builds that don't come with `fr` lang packs. > > mcs, brade could you have a second look? r=brade,r=mcs The patch looks good to us. Regarding upstreaming, it seems like the choice is to include the en-US properties files or hard-coded a bunch of strings. Including the en-US files seems like a good solution, but I guess we will see what the Mozilla engineers say. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30683#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs