#30544: Using try-with-resources or close resource
-----------------------------+--------------------------------
Reporter: fava | Owner: metrics-team
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/Library | Version:
Severity: Major | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):
* status: new => needs_revision
Comment:
This took much longer than it should have, sorry for that. Trying to get
faster with future reviews!
Here's what I found:
- There are some minor whitespace issues. Please run `ant checks` before
submitting a patch.
- Those TODO comments look reasonable, but let's maybe try to just fix
them now, each of them in a separate commit. Otherwise we'll just collect
more things to do in the sources.
- Our commit messages typically start with a roughly 50 chars long
summary line, followed by two newlines, followed by text wrapped to 70
chars. Can you try to rephrase your commit messages accordingly?
- Can you rebase your edited commits to master?
- When you post a patch or branch, be sure to change status to
needs_review. To be clear, this is not the main reason for us not
reviewing sooner, but it could be a possible reason for future delays.
Thanks again!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30544#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
