#31088: Check IPv4 and IPv6 private addresses in descriptors, first hops, and extends -------------------------------------------------+------------------------- Reporter: teor | Owner: neel Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | unspecified Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: ipv6, tor-relay, tor-client, tor- | Actual Points: dirauth | Parent ID: #24403 | Points: Reviewer: nickm | Sponsor: -------------------------------------------------+------------------------- Changes (by neel):
* status: needs_revision => needs_review Comment: I have made the changes. Replying to [comment:4 nickm]: > Two issues. > > First, have a look at your checks in circuit_extend(): it will make the extend cell get rejected only when *BOTH* of the target addresses are internal. I don't think that's right. I fixed it. > Second, I see that in dirserv_router_has_valid_address() you're testing the address for is_null, but in circuit_extend() you aren't. What's the reasoning there? I originally planned to do this in the if statement, but broke off it. I decided to remove the is_null check and pushed it also. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31088#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs