#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it -------------------------------------------------+------------------------- Reporter: Rezonansowy | Owner: tbb- | team Type: defect | Status: | needs_revision Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: AffectsTails, tbb-parity, ux-team, | Actual Points: GeorgKoppen201907, TorBrowserTeam201907, | tbb-9.0-must-nightly | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by gk): Replying to [comment:75 acat]: > > Removing `example A` etc. makes me a bit nervous. It got introduced in #15086 back then. I am not sure whether that part has been essential on solving the RTL issues but we should double-check that we don't have weird regressions, in particular as all the other code surrounding the `<li>` elements, like styling is left untouched. > I tested with current torbutton extension and tor-browser, removing example A, B... does not break the RTL with farsi. > > > >Yes, regarding your first and second question. I think there is no need for a translation repo patch. Just do the patch in Torbutton and it will propagate once someone commits the changes to master. The patch could be in #24653 which could be on top of the general #10760 patch for review. We can squash that one in a later rebasing then if we think that's useful. (If you go that route please make #24653 a child bug of this ticket so we don't lose track here) > Ok, tracking this in #24653. > > mcs mentioned there are asserts when building the browser with debugging enabled, and these are caused by torbutton, because some `QueryInterface: ChromeUtils.generateQI` have nsISupports in it. I removed these in https://www.github.com/acatarineu/torbutton/commit/10760+1 and verified that the asserts disappear. These changes were already present in #28745, but perhaps it's worth also having these here for the nightly. > > Apart from this, is anything else needed here, or we are good? I think we are good here then, thanks! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:76> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs