#31385: Snowflake client fails after bootstrap -------------------------------------+----------------------------- Reporter: cypherpunks | Owner: cohosh Type: defect | Status: merge_ready Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------+-----------------------------
Comment (by cohosh): Replying to [comment:20 arlolra]: > > Can someone review this ASAP and I'll push an update? > > Yeah, looks like this was the intention in `2521f4f`. > > Couple of notes, L89 in proxy/snowflake.js is redundant, > > {{{ > if (pair.active) { > ... > } else { > return pair.active = false; > } > }}} > > Also, since the timeout sets up a race, maybe add a `this.active` check in `channel.onopen`. > Thanks! I added a fix for both of these comments to the same branch. > I guess this is another reason to tackle #31310 Yeah. I think there's still some problems here caused by reusing proxy pairs (if the pair is reused the active check in onopen might pass even though it's meant for a different client), but this is probably okay in the short term especially since we have so few clients. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31385#comment:21> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs