#29461: Add a Snowflake module
-------------------------------------------------+-------------------------
 Reporter:  irl                                  |          Owner:
                                                 |  metrics-team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Metrics/CollecTor                    |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  metrics-roadmap-august, anti-        |  Actual Points:
  censorship-roadmap-september                   |
Parent ID:                                       |         Points:  8
 Reviewer:  irl                                  |        Sponsor:
                                                 |  Sponsor28
-------------------------------------------------+-------------------------

Comment (by karsten):

 Replying to [comment:33 notirl]:
 > Again the startProcessing() method in the Downloader is huge. Testing
 and review would be easier if this were broken up. This one is easier to
 follow though.

 Thanks for the review! I broke up the method to take out the HTTP GET and
 writing to disk.

 > We should file a ticket to refactor HTTP GET request code into a util
 function.

 Agreed. Filed #31599 for this.

 > I think we already had a ticket to refactor cleaning up directory after
 X days? If we don't then we should file that ticket.

 Yes, that's #20546.

 > The create-tarballs script was updated, but the PROTOCOL was not
 updated, for the monthly tarballs.

 Oops, fixed.

 Please take another look:
 
[https://gitweb.torproject.org/user/karsten/collector.git/commit/?h=task-29461&id=eeb9f2018c217fb56f1d08f2389319a5a08cf165
 commit eeb9f20 in my task-29461 branch].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29461#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to