#31594: Close all the log fds before aborting
-------------------------------------------------+-------------------------
Reporter: teor | Owner: (none)
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: diagnostics, 042-should, android, | Actual Points: 0.5
macos, 035-backport, 040-backport, |
041-backport |
Parent ID: #31571 | Points: 0.3
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: new => needs_review
* reviewer: => nickm
* actualpoints: => 0.5
Comment:
There were a lot of really tricky related bugs here. And I'm not sure if I
got them right. So I made a separate child ticket for each one.
Here is a draft PR that I think fixes all those bugs:
* master: https://github.com/torproject/tor/pull/1289
Here's what I still need to do:
* changes files
Here's what I don't know:
* when we clear the list of error fds, should we use -1 or 0 as the
placeholder value?
* are any of these bugs serious? Do they need a backport?
* should I split this PR up into multiple PRs?
* the subsys changes are independent
* the backtrace changes are independent
* the torerr changes need to be merged before the log changes
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31594#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
