#31568: Update How to Create Gradle Dependencies
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, ff68-esr, tbb-9.0-must- | Actual Points:
alpha, TorBrowserTeam201909 |
Parent ID: #30324 | Points: 0.25
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Replying to [comment:12 sisbell]:
> Try these changes. I'll do some more testing as well
>
> https://github.com/sisbell/tor-browser-
build/commit/80c7ad7e56c4106c063ec63ecd6acf66e3859daf
No dice. Testing the `tor-onion-proxy-library` deps I can see that the
list checked in has 277 entries while the list I get following your steps
has 313 entries. On closer inspection it turns out that your commands do
not eliminate all duplicates. E.g. on my list I get
{{{
https://dl.google.com/dl/android/maven2/com/android/tools/analytics-
library/protos/26.1.0/protos-26.1.0.jar
https://dl.google.com/dl/android/maven2/com/android/tools/analytics-
library/protos/26.1.0/protos-26.1.0.pom
}}}
and
{{{
https://repo.spring.io/plugins-release/com/android/tools/analytics-
library/protos/26.1.0/protos-26.1.0.jar
https://repo.spring.io/plugins-release/com/android/tools/analytics-
library/protos/26.1.0/protos-26.1.0.pom
}}}
By inspecting the log I see for the latter:
{{{
08:50:16.937 [DEBUG]
[org.gradle.internal.resource.transport.http.HttpClientHelper] Performing
HTTP HEAD: https://repo.spring.io/plugins-release/com/android/tools
/analytics-library/protos/26.1.0/protos-26.1.0.jar
}}}
and below interestingly
{{{
08:50:17.105 [INFO]
[org.gradle.internal.resource.transfer.DefaultCacheAwareExternalResourceAccessor]
Found locally available resource with matching checksum:
[https://repo.spring.io/plugins-release/com/android/tools/analytics-
library/protos/26.1.0/protos-26.1.0.jar, /var/tmp/dist/android-
toolchain/gradle/caches/modules-2/files-2.1/com.android.tools.analytics-
library/protos/26.1.0/1e2d35fcc1668730a6c6be29e61fbd059278f243/protos-26.1.0.jar]
}}}
So, it's performing something but later decides that the actual fetch is
not needed as there is already something cached in the toolchain
available.
I wonder why the first fetch is needed then at all and whether we could
just nuke the gradle cache when constructing the list. I'll try the
latter.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31568#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
