#29013: Provide stack smashing protection for mingw-clang builds -------------------------------------------------+------------------------- Reporter: gk | Owner: tbb- | team Type: enhancement | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-rbm, GeorgKoppen201910, | Actual Points: 1.5 tbb-9.0, TorBrowserTeam201910R | Parent ID: | Points: 1 Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by gk):
* keywords: tbb-rbm, GeorgKoppen201910, tbb-9.0, TorBrowserTeam201910 => tbb-rbm, GeorgKoppen201910, tbb-9.0, TorBrowserTeam201910R * status: new => needs_review * actualpoints: => 1.5 Comment: Replying to [comment:27 gk]: > So, not adding `libssp.dll.a` solves actually both issues I had (the dynamically linking and the crashes). I might be tempted to pick this up to get it still into 9.0 or 9.5a1 if the former is too risky. :) (thanks again, Martin) Here we are. `bug_29013_v5` (https://gitweb.torproject.org/user/gk/tor- browser- build.git/commit/?h=bug_29013_v5&id=562fe8f1df0de8912c9eaf7ff8c3b4d989d4aa01) in my `tor-browser-build` repo and `bug_29013_v2` (https://gitweb.torproject.org/user/gk/tor- browser.git/commit/?h=bug_29013_v2&id=cb5ccc9e3b50e9d37a4c7a34a0c81418df38adfe) in my `tor-browser` one. The first patch is using our own `mingw-w64` which we build anyway and is just copying the .a libs over. The `tor-browser` patch essentially backs out the special treatment of mingw-w64-clang. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29013#comment:31> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs