#31840: Refactor some control error-handling code ------------------------------------+------------------------------------ Reporter: teor | Owner: teor Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Tor: 0.4.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt 042-can | Actual Points: 0.1 Parent ID: | Points: 0.1 Reviewer: catalyst | Sponsor: Sponsor31-can ------------------------------------+------------------------------------ Changes (by catalyst):
* status: needs_review => needs_revision Comment: Replying to [comment:1 teor]: > See my PR: > * master: https://github.com/torproject/tor/pull/1358 Thanks! This code (and the existing version) looks uncovered, which makes me slightly nervous. The changes also look to be almost pure code movement so that might be safe. I left some minor comments on the pull request, mostly about naming. Feel free to address them if you like, and set to merge_ready once CI passes on any changes. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31840#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs