#28942: Evaluate pion WebRTC --------------------------------------------+------------------------------ Reporter: backkem | Owner: cohosh Type: enhancement | Status: merge_ready Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: anti-censorship-roadmap-august | Actual Points: Parent ID: | Points: 5 Reviewer: | Sponsor: | Sponsor28-must --------------------------------------------+------------------------------ Changes (by dcf):
* status: needs_review => merge_ready Comment: Replying to [comment:64 cohosh]: > I'll put this into needs_review now. Here's a commit that bumps the version of webrtc and removes the need for the patch: https://github.com/cohosh/tor-browser- build/commit/873685ba2a4756176bf2a680563f09d297cd3a50 > > And the rebased pion branch of snowflake: https://github.com/cohosh/snowflake/compare/pion I think this is ready to merge into master. > While being able to [https://github.com/cohosh/snowflake/commit/ef59d09f7cef7970e34efa18da0612e38f8f5002 being able to use the pion logs] would be nice, we need Go 1.13 to do it nicely, and we haven't yet bumped the version for Tor Browser builds. I would like to cherry-pick [https://github.com/cohosh/snowflake/commit/f370a4f296de432c392c6fc2f204fd3877a60429 adding locks to safelog] though. > > Note also that starting with [https://github.com/pion/webrtc/releases/tag/v2.1.4 v2.1.4], pion/webrtc is moving to Go 1.13. I'm not sure yet if it can still be built with Go 1.12. I think we'll need to file a ticket to upgrade to Go 1.13 (actually 1.13.1 now) in Tor Browser. The thing to watch out for is [https://golang.org/doc/go1.13#modules changed defaults relating to modules]. Now `$GOPATH` will be ignored in any directory that contains a go.mod file--so we'll have to make sure that the libraries we stage in `$GOPATH` are being used, and separate copies not being downloaded implicitly by `go build`. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28942#comment:66> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs