#31144: ESR68 Network Code Review -------------------------------------------------+------------------------- Reporter: pili | Owner: tbb- | team Type: task | Status: | needs_review Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201910R, tbb-9.0 | Actual Points: -must-alpha, tbb-proxy-bypass | Parent ID: | Points: 10 Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by sysrqb): >> CustomTabsActivity.java - Several methods emit potentially external Intents > My only concern here is onLoadRequest() when the scheme isn't handled by the browser. That's the only place where the user wasn't prompted. I don't know how the customtabs UI should handle this situation. We can break this functionality for now, until we find how this should be done correctly. This is included in the patch for #26529, but in this case we don't prompt. #26529 seemed like the better commit, but I can move this into its own commit. {{{ diff --git a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java index c75962da35a7..438f462755f6 100644 --- a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java +++ b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java @@ -618,7 +618,8 @@ public class CustomTabsActivity extends AppCompatActivity final Intent intent = new Intent(Intent.ACTION_VIEW); intent.setData(uri); try { - startActivity(intent); + // Bug 31144 - Don't know how to handle this case. + //startActivity(intent); } catch (ActivityNotFoundException e) { Log.w(LOGTAG, "No activity handler found for: " + request.uri); } }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31144#comment:23> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs