#19859: Expose stream isolation information to controllers -------------------------------------------------+------------------------- Reporter: nickm | Owner: (none) Type: enhancement | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs tor-control dns isolation | Actual Points: needs-spec needs-design term-project | Parent ID: | Points: 3 Reviewer: nickm | Sponsor: -------------------------------------------------+-------------------------
Comment (by JeremyRand): Updated spec and code patches at https://notabug.org/JeremyRand/torspec/src/stream-event-isolation (commit hash `54a7ad226cba634ae321a9f3f542ce2ff03ef302`) and https://notabug.org/JeremyRand/tor/src/stream-socks-auth (commit hash `736322ce6198f97957a83b89dcf57aab91ca9a97`). A unit test is now present, the argument is now const as requested, and I also added a `HTTPCONNECT` client protocol to both the spec and code (not sure why I neglected to do that initially). Alas, I wasn't comfortable refactoring `control_event_stream_status`, as I'm insufficiently confident in both my C skills and my familiarity with the Tor daemon codebase to really want to touch that code... I'd be worried that I'd introduce a bug. Probably safer to let someone else who has better familiarity with that code do it. @nickm, feel free to review these, as I *think* I've made all of the needed changes. Also I tested the code patch with Namecoin's stream isolation code yesterday, and everything appears to work properly (specifically, I confirmed that Tor Browser's New Identity button, New Tor Circuit button, and first-party domain isolation all work correctly with Namecoin when this patch is applied to the Tor daemon, so that at least confirms that the NYM_EPOCH, SOCKS auth, and ISO_FIELDS fields are working with real-world software). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19859#comment:20> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs