#32527: rbm downloads 0B sig file if network drops; rejects sig on next run -----------------------------------+------------------------------ Reporter: JeremyRand | Owner: boklm Type: defect | Status: needs_review Priority: Medium | Milestone: Component: Applications/rbm | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201911R | Actual Points: 0.2 Parent ID: | Points: Reviewer: | Sponsor: -----------------------------------+------------------------------ Changes (by boklm):
* status: new => needs_review * keywords: => TorBrowserTeam201911R * actualpoints: => 0.2 Comment: I think this is an issue for signatures files, but also for any files downloaded in `input_files`. The issue is that if `wget` fails for some reason, the partially downloaded files is left in the destination. We can fix that by first downloading the file to a temporary file, and only rename it to the destination if the download was successful. This is was I did in my branch `bug_32527_v2`: https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_32527_v2&id=dad4ab355d754d650d5d6ad2cccd9931b931c0ff -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32527#comment:1> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs